-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clean up CODEOWNERS #47451
Merged
Merged
chore: clean up CODEOWNERS #47451
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5dec89f
chore: clean up CODEOWNERS
balazsorban44 47d5121
Merge branch 'canary' into chore/codeowners-cleanup
balazsorban44 25fd7dc
Merge branch 'canary' into chore/codeowners-cleanup
kodiakhq[bot] 4792422
Merge branch 'canary' into chore/codeowners-cleanup
kodiakhq[bot] c2a9091
Merge branch 'canary' into chore/codeowners-cleanup
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,28 @@ | ||
| # Learn how to add code owners here: | ||
| # https://help.github.com/en/articles/about-code-owners | ||
|
|
||
| * @timneutkens @ijjk @shuding @huozhi @feedthejim | ||
| /.github/ @vercel/next-js | ||
| /docs/ @timneutkens @ijjk @shuding @huozhi @feedthejim @styfle @padmaia @leerob @balazsorban44 @jankaifer | ||
| /errors/ @timneutkens @ijjk @shuding @huozhi @feedthejim @styfle @padmaia @leerob @balazsorban44 @jankaifer | ||
| /examples/ @timneutkens @ijjk @shuding @feedthejim @leerob @steven-tey @balazsorban44 @jankaifer | ||
| * @timneutkens @ijjk @shuding @huozhi @feedthejim | ||
| /.github/ @vercel/next-js | ||
| /docs/ @vercel/next-js @leerob | ||
| /errors/ @vercel/next-js @leerob | ||
| /examples/ @vercel/next-js @leerob @steven-tey | ||
| /scripts/ @vercel/next-js | ||
| /.* @vercel/next-js @leerob | ||
| /*.md @vercel/next-js @leerob | ||
| /packages/create-next-app/ @vercel/next-js | ||
|
|
||
| # SWC Build & Telemetry (@padmaia) | ||
|
|
||
| /packages/next/build/ @timneutkens @ijjk @shuding @padmaia @huozhi | ||
| /packages/next/telemetry/ @timneutkens @ijjk @shuding @padmaia | ||
| /packages/next-swc/ @timneutkens @ijjk @shuding @vercel/web-tooling | ||
| /packages/next/build/swc/ @timneutkens @ijjk @shuding @vercel/web-tooling | ||
| /packages/next/build/ @timneutkens @ijjk @shuding @padmaia @huozhi | ||
| /packages/next/telemetry/ @timneutkens @ijjk @shuding @padmaia | ||
| /packages/next-swc/ @timneutkens @ijjk @shuding @vercel/web-tooling | ||
| /packages/next/build/swc/ @timneutkens @ijjk @shuding @vercel/web-tooling | ||
|
|
||
| # Image Component (@styfle) | ||
|
|
||
| /**/*image* @timneutkens @ijjk @shuding @styfle | ||
| /**/*image*/** @timneutkens @ijjk @shuding @styfle | ||
| /packages/next/client/use-intersection.tsx @timneutkens @ijjk @shuding @styfle | ||
| /packages/next/server/lib/squoosh/ @timneutkens @ijjk @shuding @styfle | ||
| /packages/next/server/serve-static.ts @timneutkens @ijjk @shuding @styfle | ||
| /packages/next/server/config.ts @timneutkens @ijjk @shuding @styfle | ||
| /**/*image* @timneutkens @ijjk @shuding @styfle | ||
| /**/*image*/** @timneutkens @ijjk @shuding @styfle | ||
| /packages/next/client/use-intersection.tsx @timneutkens @ijjk @shuding @styfle | ||
| /packages/next/server/lib/squoosh/ @timneutkens @ijjk @shuding @styfle | ||
| /packages/next/server/serve-static.ts @timneutkens @ijjk @shuding @styfle | ||
| /packages/next/server/config.ts @timneutkens @ijjk @shuding @styfle | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What other
.folders should the whole team be requested on?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's dotfiles, not the folders. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this matching only folders or does it match the dot files too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to double-check:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax
https://git-scm.com/docs/gitignore#_pattern_format
So as I understand, this only matches files (which was my intention in the PR)