Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typescript errors in next-core #47607

Merged
merged 7 commits into from
Mar 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/next-swc/crates/next-core/js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@
"license": "UNLICENSED",
"private": true,
"scripts": {
"build": "pnpm build:compiled && pnpm check",
"build:compiled": "node build.mjs",
"check": "tsc --noEmit",
"build:compiled": "node build.mjs"
"dev": "pnpm build"
},
"dependencies": {
"@vercel/turbopack-dev-runtime": "https://gitpkg.now.sh/vercel/turbo/crates/turbopack-dev/js?turbopack-230321.3",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import ReactDOMClient from "react-dom/client";
import React, { use } from "react";
import type { ReactElement } from "react";
// @ts-expect-error
import { version } from "next/package.json";
import { createFromReadableStream } from "next/dist/compiled/react-server-dom-webpack/client";
import { callServer } from 'next/dist/client/app-call-server';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,5 @@ import * as serverHooks from "next/dist/client/components/hooks-server-context.j
export { serverHooks };
export { renderToReadableStream } from "next/dist/compiled/react-server-dom-webpack/server.edge";

// @ts-expect-error PAGE is provided by rust
import * as module from "PAGE";
export { module };
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { requestAsyncStorage } from "next/dist/client/components/request-async-s

enhanceGlobals();

// @ts-expect-error ENTRY is set from rust code
import * as handlers from "ENTRY";
const mod = {
handlers,
Expand All @@ -25,6 +24,7 @@ const mod = {
const handler = getHandle({
mod,
page: `/${PAGE}`,
nextConfigOutput: undefined
});

// @ts-ignore
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
startHandler(async ({ request, response, query, params, path }) => {
const edgeInfo = {
name: "edge",
paths: chunkGroup.map((chunk: string) =>
paths: chunkGroup.map((chunk) =>
join(process.cwd(), ".next/server/app", chunk)
),
wasm: [],
Expand Down