Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning for metadataBase fallback #48196

Merged
merged 2 commits into from Apr 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/next/src/lib/metadata/resolvers/resolve-url.ts
@@ -1,5 +1,4 @@
import path from '../../../shared/lib/isomorphic/path'
import * as Log from '../../../build/output/log'

function isStringOrURL(icon: any): icon is string | URL {
return typeof icon === 'string' || icon instanceof URL
Expand All @@ -26,11 +25,6 @@ function resolveUrl(

if (!metadataBase) {
metadataBase = new URL(`http://localhost:${process.env.PORT || 3000}`)
// Development mode warning, add new line prefix for worker output
console.log()
Log.warn(
`metadata.metadataBase is not set for resolving url "${url}", fallbacks to "${metadataBase.origin}". See https://beta.nextjs.org/docs/api-reference/metadata#metadatabase`
)
}

// Handle relative or absolute paths
Expand Down

This file was deleted.

This file was deleted.

12 changes: 0 additions & 12 deletions test/e2e/app-dir/metadata-missing-metadata-base/app/layout.js

This file was deleted.

31 changes: 0 additions & 31 deletions test/e2e/app-dir/metadata-missing-metadata-base/index.test.ts

This file was deleted.

This file was deleted.