Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not suggest adding "use client" if using next/router in app #48680

Merged
merged 3 commits into from Apr 21, 2023
Merged

Do not suggest adding "use client" if using next/router in app #48680

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
041137d
do not suggest adding use client when used next/router in app
shuding Apr 21, 2023
d95a859
Merge branch 'canary' into shu/fe26
shuding Apr 21, 2023
50c7f14
Merge branch 'canary' into shu/fe26
kodiakhq[bot] Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/next/src/build/webpack/plugins/wellknown-errors-plugin/parseRSC.ts
View file
Open in desktop
Expand Up @@ -40,6 +40,7 @@ function formatRSCErrorMessage(
formattedVerboseMessage =
'\n\nMaybe one of these should be marked as a client entry with "use client":\n'
} else if (NEXT_RSC_ERR_SERVER_IMPORT.test(message)) {
let shouldAddUseClient = true
const matches = message.match(NEXT_RSC_ERR_SERVER_IMPORT)
switch (matches && matches[1]) {
case 'react-dom/server':
Expand All @@ -49,15 +50,17 @@ function formatRSCErrorMessage(
case 'next/router':
// If importing "next/router", we should tell them to use "next/navigation".
formattedMessage = `\n\nYou have a Server Component that imports next/router. Use next/navigation instead.`
shouldAddUseClient = false
break
default:
formattedMessage = message.replace(
NEXT_RSC_ERR_SERVER_IMPORT,
`\n\nYou're importing a component that imports $1. It only works in a Client Component but none of its parents are marked with "use client", so they're Server Components by default.\n\n`
)
}
formattedVerboseMessage =
'\n\nMaybe one of these should be marked as a client entry "use client":\n'
formattedVerboseMessage = shouldAddUseClient
? '\n\nMaybe one of these should be marked as a client entry "use client":\n'
: '\n\nImport trace:\n'
} else if (NEXT_RSC_ERR_CLIENT_IMPORT.test(message)) {
if (isPagesDir) {
formattedMessage = message.replace(
Expand Down