Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Azure Cosmos DB started code, containing a minimal app and README.md #49128

Merged
merged 6 commits into from Jun 8, 2023

Conversation

v1k1
Copy link
Contributor

@v1k1 v1k1 commented May 3, 2023

These changes contain Started Code for Azure Cosmos DB.

@v1k1 v1k1 requested review from a team, leerob and steven-tey as code owners May 3, 2023 06:28
@ijjk ijjk added the examples Issue/PR related to examples label May 3, 2023
@v1k1
Copy link
Contributor Author

v1k1 commented May 11, 2023

Hey @leerob @steven-tey, I am from Microsoft @azure/cosmos JS SDK team. We are currently working on Vercel and Azure Cosmos DB integration. Can you please review this PR containing sample starter code to get started with Next.js and Azure Cosmos DB. Thanks.

@Enngage
Copy link

Enngage commented May 31, 2023

Hey @v1k1 and Next.js team,

When I looked at the code I was hoping to see some sort of integration in the sense that we could leverage the request deduping (https://nextjs.org/docs/app/building-your-application/data-fetching#automatic-fetch-request-deduping), but it seems that if you are using CosmosDb, every single GET call is in fact called each time you request it.

Is there a way of leveraging the fetch for making CosmosDB queries? Or do we have to use cache manually? (https://nextjs.org/docs/app/building-your-application/data-fetching/caching#react-cache). Would be great if this was automatic and if would be possible to use custom HTTP adapter for Cosmos Db client.

}
}

const Home = (props: Props) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to update this to use the App Router but non-blocking.

@leerob leerob enabled auto-merge (squash) June 7, 2023 16:34
@ijjk
Copy link
Member

ijjk commented Jun 7, 2023

Allow CI Workflow Run

  • approve CI run for commit: a310974

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@styfle styfle disabled auto-merge June 8, 2023 18:59
@kodiakhq kodiakhq bot merged commit 13bd196 into vercel:canary Jun 8, 2023
62 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants