Fixed #48483 #49694
Closed
Fixed #48483 #49694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue vercel#48483 by adding a Head tag with the a link to the ant design css. I did this because the issue was related to server-side rendering, where the HTML generated on the server did not include the necessary CSS styles for the Ant Design components, leading to a flash of unstyled components on page load. By adding the <Head> tag and including the necessary CSS styles, we were able to ensure that the CSS is included in the HTML generated on the server, thereby avoiding the flash of unstyled components.
dimaMachina
reviewed
May 15, 2023
| @@ -26,6 +28,10 @@ export default function Home() { | |||
| } | |||
|
|
|||
| return ( | |||
| <div> | |||
| <Head> | |||
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/antd/dist/antd.css" /> | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
thanks for the heads up ! I'll make the necessary changes.
There was a problem hiding this comment.
Hi @B2o5T
I have made the changes according to your suggestion.
To prevent the flash of unstyled content in my Next.js application, I added a custom Document component. In this component, I included a link to the Ant Design CSS stylesheet within the <Head> section. This ensures that the styles from Ant Design are loaded and applied to the page during server-side rendering (SSR). By extending the default Document component, I was able to customize the HTML structure of the page and include the necessary styles, providing a seamless and styled user experience
|
Hi @B2o5T could you review my pull request? |
|
Hi, I am not part of Next.js team, ping them instead |
|
@leerob @steven-tey Could you review my pull request? |
|
Closing this out, as we'd like to move the example to use the App Router instead 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixed issue #48483- There was a flash of unstyled design in the with-ant-design example in the repo.
How
Created a _document.tsx file with a head component with a link to the ant design stylesheet.
Why
To prevent the flash of unstyled content in my Next.js application, I added a custom Document component. In this component, I included a link to the Ant Design CSS stylesheet within the section. This ensures that the styles from Ant Design are loaded and applied to the page during server-side rendering (SSR). By extending the default Document component, I was able to customize the HTML structure of the page and include the necessary styles, providing a seamless and styled user experience.