feat(examples): update with-storybook to v7 #49863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Socket Security: Pull Request Alerts is failing, most likely due to updates in package.json. It happened for mee too. |
leerob
reviewed
Jun 15, 2023
| @@ -5,4 +5,4 @@ export default { | |||
| component: NextjsImages, | |||
| } | |||
|
|
|||
| export const NextjsImagesPage = () => <NextjsImages /> | |||
| export const NextjsImagesPage = {} | |||
| "@storybook/manager-webpack5": "^6.4.9", | ||
| "@storybook/react": "^6.4.9", | ||
| "babel-loader": "^8.2.3", | ||
| "@storybook/addon-actions": "^7.0.12", |
There was a problem hiding this comment.
Could we make sure these are on latest?
|
Thanks, but this has been addressed already in #50865, so closing this PR! 💚 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updating
with-storybookexample to use Storybook v7Why?
Storybook v7 is released and it has zero-config Next.js support.
(and I had a chance to create a minimal repo.)