Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify manual graceful shutdown in dev server #50481

Closed
wants to merge 3 commits into from

Conversation

dmgawel
Copy link

@dmgawel dmgawel commented May 29, 2023

For Contributors

Improving Documentation or adding/fixing Examples

What?

Clarifies that manual signal handling for graceful shutdown in dev server mode is not available.

Why?

Manual signal handling was removed from dev server in #42255

@dmgawel dmgawel requested review from a team and leerob as code owners May 29, 2023 08:42
docs/deployment.md Outdated Show resolved Hide resolved
Co-authored-by: Michael Novotny <manovotny@gmail.com>
@manovotny
Copy link
Contributor

This is my fault. This doc doesn't even exist anymore at this location because we replaced everything with the new doc structure.

Ported the change to #51078.

@manovotny manovotny closed this Jun 10, 2023
leerob added a commit that referenced this pull request Jun 10, 2023
Replaces #50481

---------

Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
Co-authored-by: Lee Robinson <me@leerob.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants