Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't add forceConsistentCasingInFileNames to tsconfig when ts version >= 5.0 #51564

Merged
merged 8 commits into from Aug 15, 2023
+3 −15
Merged

fix: don't add forceConsistentCasingInFileNames to tsconfig when ts version >= 5.0 #51564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3914e2d
fix: don't add forceConsistentCasingInFileNames to tsconfig when type…
stefanprobst Jun 20, 2023
de31521
Merge branch 'canary' into fix/drop-tsconfig-forceconsistentcasinginf…
stefanprobst Jun 26, 2023
b5f12bf
Merge branch 'canary' into fix/drop-tsconfig-forceconsistentcasinginf…
styfle Jul 25, 2023
4184571
test: update inline snapshots
stefanprobst Jul 25, 2023
65f2bc1
Merge branch 'canary' into fix/drop-tsconfig-forceconsistentcasinginf…
styfle Jul 25, 2023
96eee73
Merge branch 'canary' into fix/drop-tsconfig-forceconsistentcasinginf…
ztanner Aug 15, 2023
46f4523
Merge branch 'canary' into fix/drop-tsconfig-forceconsistentcasinginf…
kodiakhq[bot] Aug 15, 2023
70e8425
Merge branch 'canary' into fix/drop-tsconfig-forceconsistentcasinginf…
ztanner Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/create-next-app/templates/app-tw/ts/tsconfig.json
View file
Open in desktop
Expand Up @@ -5,7 +5,6 @@
"allowJs": true,
"skipLibCheck": true,
"strict": true,
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"esModuleInterop": true,
"module": "esnext",
Expand Down
1 change: 0 additions & 1 deletion packages/create-next-app/templates/app/ts/tsconfig.json
View file
Open in desktop
Expand Up @@ -5,7 +5,6 @@
"allowJs": true,
"skipLibCheck": true,
"strict": true,
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"esModuleInterop": true,
"module": "esnext",
Expand Down
1 change: 0 additions & 1 deletion packages/create-next-app/templates/default-tw/ts/tsconfig.json
View file
Open in desktop
Expand Up @@ -5,7 +5,6 @@
"allowJs": true,
"skipLibCheck": true,
"strict": true,
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"esModuleInterop": true,
"module": "esnext",
Expand Down
1 change: 0 additions & 1 deletion packages/create-next-app/templates/default/ts/tsconfig.json
View file
Open in desktop
Expand Up @@ -5,7 +5,6 @@
"allowJs": true,
"skipLibCheck": true,
"strict": true,
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"esModuleInterop": true,
"module": "esnext",
Expand Down
4 changes: 3 additions & 1 deletion packages/next/src/lib/typescript/writeConfigurationDefaults.ts
View file
Open in desktop
Expand Up @@ -28,7 +28,9 @@ function getDesiredCompilerOptions(
allowJs: { suggested: true },
skipLibCheck: { suggested: true },
strict: { suggested: false },
forceConsistentCasingInFileNames: { suggested: true },
...(semver.lt(ts.version, '5.0.0')
? { forceConsistentCasingInFileNames: { suggested: true } }
: undefined),
noEmit: { suggested: true },
...(semver.gte(ts.version, '4.4.2')
? { incremental: { suggested: true } }
Expand Down
10 changes: 0 additions & 10 deletions test/integration/tsconfig-verifier/test/index.test.js
View file
Open in desktop
Expand Up @@ -34,7 +34,6 @@ describe('tsconfig.json verifier', () => {
\\"allowJs\\": true,
\\"skipLibCheck\\": true,
\\"strict\\": false,
\\"forceConsistentCasingInFileNames\\": true,
\\"noEmit\\": true,
\\"incremental\\": true,
\\"esModuleInterop\\": true,
Expand Down Expand Up @@ -89,7 +88,6 @@ describe('tsconfig.json verifier', () => {
\\"allowJs\\": true,
\\"skipLibCheck\\": true,
\\"strict\\": false,
\\"forceConsistentCasingInFileNames\\": true,
\\"noEmit\\": true,
\\"incremental\\": true,
\\"esModuleInterop\\": true,
Expand Down Expand Up @@ -163,7 +161,6 @@ describe('tsconfig.json verifier', () => {
\\"allowJs\\": true,
\\"skipLibCheck\\": true,
\\"strict\\": false,
\\"forceConsistentCasingInFileNames\\": true,
\\"noEmit\\": true,
\\"incremental\\": true,
\\"moduleResolution\\": \\"node\\",
Expand Down Expand Up @@ -218,7 +215,6 @@ describe('tsconfig.json verifier', () => {
\\"allowJs\\": true,
\\"skipLibCheck\\": true,
\\"strict\\": false,
\\"forceConsistentCasingInFileNames\\": true,
\\"noEmit\\": true,
\\"incremental\\": true,
\\"moduleResolution\\": \\"node\\",
Expand Down Expand Up @@ -270,7 +266,6 @@ describe('tsconfig.json verifier', () => {
\\"allowJs\\": true,
\\"skipLibCheck\\": true,
\\"strict\\": false,
\\"forceConsistentCasingInFileNames\\": true,
\\"noEmit\\": true,
\\"incremental\\": true,
\\"moduleResolution\\": \\"node\\",
Expand Down Expand Up @@ -326,7 +321,6 @@ describe('tsconfig.json verifier', () => {
\\"allowJs\\": true,
\\"skipLibCheck\\": true,
\\"strict\\": false,
\\"forceConsistentCasingInFileNames\\": true,
\\"noEmit\\": true,
\\"incremental\\": true,
\\"module\\": \\"esnext\\",
Expand Down Expand Up @@ -382,7 +376,6 @@ describe('tsconfig.json verifier', () => {
\\"allowJs\\": true,
\\"skipLibCheck\\": true,
\\"strict\\": false,
\\"forceConsistentCasingInFileNames\\": true,
\\"noEmit\\": true,
\\"incremental\\": true,
\\"module\\": \\"esnext\\",
Expand Down Expand Up @@ -434,7 +427,6 @@ describe('tsconfig.json verifier', () => {
\\"allowJs\\": true,
\\"skipLibCheck\\": true,
\\"strict\\": false,
\\"forceConsistentCasingInFileNames\\": true,
\\"noEmit\\": true,
\\"incremental\\": true,
\\"esModuleInterop\\": true,
Expand Down Expand Up @@ -493,7 +485,6 @@ describe('tsconfig.json verifier', () => {
\\"allowJs\\": true,
\\"skipLibCheck\\": true,
\\"strict\\": false,
\\"forceConsistentCasingInFileNames\\": true,
\\"noEmit\\": true,
\\"incremental\\": true,
\\"resolveJsonModule\\": true,
Expand Down Expand Up @@ -547,7 +538,6 @@ describe('tsconfig.json verifier', () => {
\\"allowJs\\": true,
\\"skipLibCheck\\": true,
\\"strict\\": false,
\\"forceConsistentCasingInFileNames\\": true,
\\"noEmit\\": true,
\\"incremental\\": true,
\\"esModuleInterop\\": true,
Expand Down