Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Docs) add missing js version for generateMetadata. #52763

Merged
merged 3 commits into from
Jul 17, 2023
Merged

(Docs) add missing js version for generateMetadata. #52763

merged 3 commits into from
Jul 17, 2023

Conversation

vinaykulk621
Copy link
Contributor

There was no JS version for generateMetadata function.

fixes #52759

@vinaykulk621 vinaykulk621 requested review from a team as code owners July 17, 2023 03:38
@ijjk
Copy link
Member

ijjk commented Jul 17, 2023 •
edited by styfle

Allow CI Workflow Run

  • approve CI run for commit: 438ea2f

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Jul 17, 2023 •
edited by styfle

Allow CI Workflow Run

  • approve CI run for commit: 438ea2f

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

styfle
styfle previously approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 503677c into vercel:canary Jul 17, 2023
39 checks passed
@vinaykulk621 vinaykulk621 deleted the fix-missing-jsx-code branch July 17, 2023 16:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@leerob leerob Awaiting requested review from leerob leerob is a code owner automatically assigned from vercel/devex

@Nutlope Nutlope Awaiting requested review from Nutlope Nutlope is a code owner automatically assigned from vercel/devex

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: generateMetadata function bug
3 participants
@vinaykulk621 @ijjk @styfle