Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow general language codes in the Metadata API #52920

Merged
merged 7 commits into from Jul 20, 2023
Merged

Allow general language codes in the Metadata API #52920

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
71683f6
Fixed:#52898 LangCode Missing zh-Hans and zh-Hant
darshanjain-entrepreneur Jul 20, 2023
203b74f
Merge branch 'canary' into AddingLangCode-zh-Hans-And-zh-Hant
darshanjain-entrepreneur Jul 20, 2023
50e251c
Update alternative-urls-types.ts
darshanjain-entrepreneur Jul 20, 2023
92f4733
Merge branch 'canary' into AddingLangCode-zh-Hans-And-zh-Hant
darshanjain-entrepreneur Jul 20, 2023
f1ed391
use template literal
shuding Jul 20, 2023
752c201
Merge branch 'canary' into AddingLangCode-zh-Hans-And-zh-Hant
shuding Jul 20, 2023
a17887d
fix types
shuding Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/next/src/lib/metadata/types/alternative-urls-types.ts
View file
Open in desktop
Expand Up @@ -412,7 +412,15 @@ type LangCode =
| 'zh-MO'
| 'zh-SG'
| 'zh-TW'
| 'zh-Hans'
| 'zh-Hant'
| 'zu-ZA'
// We can't have all valid combinations of language-region-script listed here
// as the list is too long and breaks the TypeScript compiler. So instead we
// only add the most common ones with a general string pattern for the rest.
// This way autocompletion still works and it is still possible to add custom
// lang codes.
| `${Lowercase<string>}-${string}`

type UnmatchedLang = 'x-default'

Expand Down