Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update useParams typing to assume a given shape #55126

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Update useParams typing to assume a given shape #55126

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f311e2
Update useParams typing to assume a given shape
dvoytenko Sep 8, 2023
35d451f
add compat types as well
dvoytenko Sep 14, 2023
81457ed
Merge branch 'canary' into dimavoytenko/use-params-type
ijjk Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/next/src/client/components/navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,14 +164,14 @@ function getSelectedParams(
* Get the current parameters. For example useParams() on /dashboard/[team]
* where pathname is /dashboard/nextjs would return { team: 'nextjs' }
*/
export function useParams(): Params {
export function useParams<T extends Params = Params>(): T {
clientHookInServerComponentError('useParams')
const globalLayoutRouterContext = useContext(GlobalLayoutRouterContext)
if (!globalLayoutRouterContext) {
// This only happens in `pages`. Type is overwritten in navigation.d.ts
return null!
}
return getSelectedParams(globalLayoutRouterContext.tree)
return getSelectedParams(globalLayoutRouterContext.tree) as T
}

// TODO-APP: handle parallel routes
Expand Down