Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix next.js own build on windows #55544

Merged
merged 5 commits into from Sep 18, 2023
+7 −3
Merged

fix next.js own build on windows #55544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8d210ed
windows fixes
sokra Sep 1, 2023
16b97d4
windows fixes for the webpack build
sokra Sep 18, 2023
9eec8d3
fix lint
ijjk Sep 18, 2023
1a0e67f
Merge branch 'canary' into sokra/webpack-config-windows
kodiakhq[bot] Sep 18, 2023
e0045f6
Merge branch 'canary' into sokra/webpack-config-windows
kodiakhq[bot] Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next/webpack.config.js
View file
Open in desktop
Expand Up @@ -191,7 +191,7 @@ module.exports = ({ dev, turbo, bundleType, experimental }) => {
module: {
rules: [
{
include: /vendored\/rsc\/entrypoints/,
include: /vendored[\\/]rsc[\\/]entrypoints/,
resolve: {
conditionNames: ['react-server', '...'],
alias: {
Expand Down
5 changes: 3 additions & 2 deletions packages/third-parties/package.json
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@
],
"license": "MIT",
"scripts": {
"build": "rm -rf dist && tsc -d -p tsconfig.json",
"build": "rimraf dist && tsc -d -p tsconfig.json",
"prepublishOnly": "cd ../../ && turbo run build",
"dev": "tsc -d -w -p tsconfig.json",
"typescript": "tsec --noEmit -p tsconfig.json"
Expand All @@ -25,7 +25,8 @@
"devDependencies": {
"next": "13.4.20-canary.38",
"outdent": "0.8.0",
"prettier": "2.5.1"
"prettier": "2.5.1",
"rimraf": "^3.0.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add a dependency here.

},
"peerDependencies": {
"next": "^13.0.0",
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.