Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: next/head: Document error cases with head/body-tags; add subheadings #56412

Merged
merged 7 commits into from
Jan 6, 2024

Conversation

tordans
Copy link
Contributor

@tordans tordans commented Oct 4, 2023

What?

Two things

  1. Add subheadings to the page to structure the unrelated sections
  2. Add a section that no <head> or <body> tags are allowed which will result in a very missleading error message
    See also Misleading "next-head-count is missing" error for invalid head tags #20924

Why?

The subheadings help with scannability of the page and give it structure.

The new section helps to understand how next/head is different from react-helmet (without referencing this explicitly). It helps to understand this very unrelated error message.

@tordans tordans requested review from a team as code owners October 4, 2023 11:25
@tordans tordans requested review from S3Prototype and delbaoliveira and removed request for a team October 4, 2023 11:25
tordans added a commit to FixMyBerlin/atlas-app that referenced this pull request Oct 10, 2023
Which, I now realize, is something I debugged before for FixMyBerlin/trassenscout@daa28fd#diff-8e1ee4a53dc84447dceb573ab344784cf5674e1d50b1fbd6833320c6b6d7b856R17-R25.

Side node: This will hopefully make this debugging easier in the future vercel/next.js#56412
@leerob leerob merged commit a95a7d6 into vercel:canary Jan 6, 2024
31 checks passed
@tordans tordans deleted the patch-2 branch January 7, 2024 15:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants