Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generate-viewport.mdx #57701

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Update generate-viewport.mdx #57701

merged 1 commit into from
Dec 24, 2023

Conversation

haritssr
Copy link
Contributor

add "type" to "{ Viewport }" type import statement

@haritssr
Update generate-viewport.mdx
60e580f 
add "type" to { Viewport } type import statement
@haritssr haritssr requested review from a team as code owners October 29, 2023 06:52
@haritssr haritssr requested review from timeyoutakeit and molebox and removed request for a team October 29, 2023 06:53
@haritssr
Copy link
Contributor Author

haritssr commented Nov 8, 2023 •
edited

Link: https://nextjs.org/docs/app/api-reference/functions/generate-viewport#the-viewport-object

leerob
leerob approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine either way AFAIK 👍

@leerob leerob merged commit 768d217 into vercel:canary Dec 24, 2023
6 checks passed
agustints pushed a commit to agustints/next.js that referenced this pull request Jan 6, 2024
@haritssr @agustints
docs: add type to import statement (vercel#57701)
9fb0f37
@github-actions github-actions bot added the locked label Jan 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@timeyoutakeit timeyoutakeit Awaiting requested review from timeyoutakeit timeyoutakeit is a code owner automatically assigned from vercel/devex

@molebox molebox Awaiting requested review from molebox molebox is a code owner automatically assigned from vercel/devex

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haritssr @leerob @ijjk