docs: add example of webhooks with App Router #60276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leerob
requested review from
manovotny and
delbaoliveira
and removed request for
a team
|
@leerob I see the emphasis here is on "simple". Does that mean we want to keep out any mentions of security or revalidation, even if it’s just |
vordgi
reviewed
Jan 5, 2024
| const text = await request.text() | ||
| // Process the webhook payload | ||
| } catch (error) { | ||
| return new Response(`Webhook error: ${error.message}`, { |
There was a problem hiding this comment.
Hello 😶🌫️. I accidentally looked in and came across something painfully familiar.
"'error' is of type 'unknown'"
But I'm not sure if it's too much to add a check in the doc like if (error instanceof Error), but on the other hand, it seems like the right thing to do, as if the example shouldn't include an error.
|
@manovotny thinking we just keep this one simple, but could make add more here in the future! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full example of one with GitHub: https://raw.githubusercontent.com/leerob/on-demand-isr/main/app/api/webhook/route.ts