-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor image optimization to separate external/internal urls #61172
Merged
styfle
merged 5 commits into
canary
from
refactor-image-optimization-external-vs-internal
Jan 26, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
06104f8
chore: refactor image optimization to separate external/internal urls
styfle e60227f
change Omit <> to specific props
styfle 796375e
Merge branch 'canary' into refactor-image-optimization-external-vs-in…
styfle df9060f
Apply suggestions for `Pick<>`
styfle eb8690d
fix: missing comma
styfle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're only using
cacheControl
fromimageUpstream
to retrieve the max age, would it be worth refactoring to havefetchImageUpstream
take care of that for us? And then have theImageUpstream
type returnmaxAge
rather thancacheControl
(unless we do needcacheControl
for some reason that I'm not seeing in this diff).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two functions:
fetchExternalImage
andfetchInternalImage
so both of them would need to callgetMaxAge()
.My PR only requires a single
getMaxAge()
.I think the inputs here make sense because it allows you to pass in the result of the upstream (buffer from the body plus relevant headers) without needing to create the shape of a NodeResponse or WebResponse.
Maybe I should rename
ImageUpstream
toImageUpstreamResponse
to make it a little more clear?