Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
next experimental-test
command #64352Add
next experimental-test
command #64352Changes from 5 commits
852c078
c7881df
34b22bc
2a5934c
e47cdb3
5e71cda
abb1434
cd41ce2
2601aa5
bd63c40
99de698
424a2ed
0ebe076
932ea29
c44f927
2a3c8a3
73b3d0e
4c53c01
7637259
fdfcf25
ff24c14
4e2b506
100e40e
e93a408
1ad8fba
d3a7644
a4f42ff
bfa407d
ca86512
860fa64
593d8ad
aaa9478
03394d9
d4d04cf
5dca6ca
f03b956
b32e9fc
3d0b1d3
9249862
2687eb3
1276382
e947996
adcc378
6902027
c8afd70
3b7a17f
310ef22
1c93145
1b44741
fa4fef1
1596290
c4a36ce
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does playwright also support
.mjs
or.json
files for config?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. I can only find references to these two in the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking nit: I like that we're setting up all the internal plumbing to support having other test runners, but maybe until we have more than 1 supported runner it's not worth exposing this config publicly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't document these options so I think it's okay. Its unclear to me how soon we'd like to add support for another test runner, so I determined it important to at least keep the implementation open ended from the beginning.