Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly rethrow instrumentation loading error #65251

Open
wants to merge 4 commits into
base: canary
Choose a base branch
from
Open

correctly rethrow instrumentation loading error #65251

wants to merge 4 commits into from
+1 −2

Commits on May 1, 2024

  1. correctly rethrow instrumentation loading error 

    we can't assume the thrown error will have a settable message property
if we do, we end up with an entirely different error thrown

Failed to prepare server TypeError: Cannot set property message of [object Object] which has only a getter
    at NextNodeServer.prepareImpl
    @iscekic
    iscekic committed May 1, 2024
    Configuration menu
    Copy the full SHA
    8571364 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. improve error description

    @iscekic
    iscekic committed May 2, 2024
    Configuration menu
    Copy the full SHA
    df94b39 View commit details
    Browse the repository at this point in the history

  2. use error cause to point to original cause of the error

    @iscekic
    iscekic committed May 2, 2024
    Configuration menu
    Copy the full SHA
    1ae88a7 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Merge branch 'canary' into correctly-rethrow-instrumentation-load-error

    @iscekic
    iscekic committed May 9, 2024
    Configuration menu
    Copy the full SHA
    310811d View commit details
    Browse the repository at this point in the history