Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update not-found.mdx #65314

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from
Open

Update not-found.mdx #65314

wants to merge 1 commit into from
+12 −0

Conversation

n-vigier
Copy link

@n-vigier n-vigier commented May 3, 2024

@n-vigier n-vigier requested review from a team as code owners May 3, 2024 07:27
@n-vigier n-vigier requested review from molebox and StephDietz and removed request for a team May 3, 2024 07:27
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label May 3, 2024
@ijjk
Copy link
Member

ijjk commented May 3, 2024

Allow CI Workflow Run

  • approve CI run for commit: d915d8e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

samcx
samcx requested changes May 3, 2024
View reviewed changes
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may be better off in the Good to know above where is now, since that seems to include any "good to knows" with not-found.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcx samcx samcx requested changes

@molebox molebox Awaiting requested review from molebox molebox is a code owner automatically assigned from vercel/devex

@StephDietz StephDietz Awaiting requested review from StephDietz StephDietz is a code owner automatically assigned from vercel/devex

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@n-vigier @ijjk @samcx