Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update reproduction templates to use correct React #65624

Merged

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented May 10, 2024

Our reproduction templates are pinned to next@canary. This updates to use the correct react & react-dom dependencies since canary is pointed to React 19.

Fixes #65619

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team examples Issue/PR related to examples labels May 10, 2024
Copy link
Member Author

ztanner commented May 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ztanner and the rest of your teammates on Graphite Graphite

@ztanner ztanner marked this pull request as ready for review May 10, 2024 19:22
@ztanner ztanner requested review from a team as code owners May 10, 2024 19:22
@ztanner ztanner requested review from ismaelrumzan and jh3y and removed request for a team May 10, 2024 19:22
@ztanner ztanner enabled auto-merge (squash) May 10, 2024 19:24
@ztanner ztanner merged commit 82a6110 into canary May 10, 2024
36 checks passed
@ztanner ztanner deleted the 05-10-update_reproduction_templates_to_use_correct_React branch May 10, 2024 19:25
panteliselef pushed a commit to panteliselef/next.js that referenced this pull request May 20, 2024
Our reproduction templates are pinned to `next@canary`. This updates to
use the correct `react` & `react-dom` dependencies since `canary` is
pointed to React 19.

Fixes vercel#65619
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create reproduction
3 participants