Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type-only imports to documentation examples #65687

Merged

Conversation

diogocapela
Copy link
Contributor

This pull request introduces type-only imports to the examples across several documentation sections.

By specifying import type, we clarify that certain imports are used only for type checking and not as part of the executable code, improving the overall documentation precision.

@diogocapela diogocapela requested review from a team as code owners May 13, 2024 09:49
@diogocapela diogocapela requested review from manovotny and delbaoliveira and removed request for a team May 13, 2024 09:49
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label May 13, 2024
@ijjk
Copy link
Member

ijjk commented May 13, 2024

Allow CI Workflow Run

  • approve CI run for commit: 8cc866b

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented May 13, 2024

Allow CI Workflow Run

  • approve CI run for commit: 8cc866b

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented May 13, 2024

Allow CI Workflow Run

  • approve CI run for commit: 52f49b0

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@diogocapela diogocapela force-pushed the add-missing-type-only-imports-on-docs branch from 8cc866b to 52f49b0 Compare May 13, 2024 10:33
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR! Looks good to me.

@samcx samcx enabled auto-merge (squash) May 13, 2024 20:34
@samcx samcx merged commit f412c5e into vercel:canary May 13, 2024
33 checks passed
panteliselef pushed a commit to panteliselef/next.js that referenced this pull request May 20, 2024
This pull request introduces type-only imports to the examples across
several documentation sections.

By specifying `import type`, we clarify that certain imports are used
only for type checking and not as part of the executable code, improving
the overall documentation precision.

Co-authored-by: Diogo Capela <d.capela@wearin.tech>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants