Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve order of spans in tracing #66516

Merged
merged 2 commits into from
Jun 4, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/next-swc/crates/next-api/src/app.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1273,7 +1273,7 @@ impl Endpoint for AppEndpoint {
}
};
async move {
let output = self.output();
let output = self.output().await?;
// Must use self.output_assets() instead of output.output_assets() to make it a
// single operation
let output_assets = self.output_assets();
Expand All @@ -1297,7 +1297,7 @@ impl Endpoint for AppEndpoint {
.await?
.clone_value();

let written_endpoint = match *output.await? {
let written_endpoint = match *output {
AppEndpointOutput::NodeJs { rsc_chunk, .. } => WrittenEndpoint::NodeJs {
server_entry_path: node_root_ref
.get_path_to(&*rsc_chunk.ident().path().await?)
Expand Down
1 change: 1 addition & 0 deletions packages/next-swc/crates/next-api/src/instrumentation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@
async move {
let this = self.await?;
let output_assets = self.output_assets();
output_assets.resolve().await?;

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / rustdoc check / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / rust check / build

unused `Vc` that must be used

Check failure on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / rust check / build

unused `turbo_tasks::Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / build / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / build-native / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test cargo unit / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test unit (18) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test unit (20) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / Test new tests for flakes (dev) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / Test new tests for flakes (prod) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / types and precompiled / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test ppr integration / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / lint / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test next-swc wasm / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test integration (10/12) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test integration (4/12) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test integration (12/12) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack development integration (2/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test integration (1/12) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test integration (6/12) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test integration (11/12) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack development integration (3/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack production integration (3/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack production integration (5/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack development integration (4/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test firefox and safari / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack production (3/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test integration (3/12) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack production integration (1/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test integration (7/12) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test ppr dev (4/4) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack development integration (1/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test integration (8/12) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test ppr dev (1/4) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test integration (9/12) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test integration (5/12) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack development integration (5/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test ppr dev (2/4) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test ppr dev (3/4) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack production (2/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test integration (2/12) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test prod (3/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test ppr prod (2/4) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test ppr prod (3/4) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack production (5/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack production integration (4/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test prod (5/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack production (1/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test ppr prod (4/4) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack production (4/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test prod (4/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test dev (3/4) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test ppr prod (1/4) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test prod (2/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test dev (2/4) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack production integration (2/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev (4/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test prod (1/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev (3/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev (1/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test dev (4/4) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev (5/5) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test dev (1/4) / build

unused `Vc` that must be used

Check warning on line 197 in packages/next-swc/crates/next-api/src/instrumentation.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev (2/5) / build

unused `Vc` that must be used
this.project
.emit_all_output_assets(Vc::cell(output_assets))
.await?;
Expand Down
1 change: 1 addition & 0 deletions packages/next-swc/crates/next-api/src/middleware.rs
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@
async move {
let this = self.await?;
let output_assets = self.output_assets();
output_assets.resolve().await?;

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / rustdoc check / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / rust check / build

unused `Vc` that must be used

Check failure on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / rust check / build

unused `turbo_tasks::Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / build / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / build-native / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test cargo unit / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test unit (18) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test unit (20) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / Test new tests for flakes (dev) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / Test new tests for flakes (prod) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / types and precompiled / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test ppr integration / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / lint / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test next-swc wasm / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test integration (10/12) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test integration (4/12) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test integration (12/12) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack development integration (2/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test integration (1/12) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test integration (6/12) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test integration (11/12) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack development integration (3/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack production integration (3/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack production integration (5/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack development integration (4/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test firefox and safari / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack production (3/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test integration (3/12) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack production integration (1/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test integration (7/12) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test ppr dev (4/4) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack development integration (1/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test integration (8/12) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test ppr dev (1/4) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test integration (9/12) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test integration (5/12) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack development integration (5/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test ppr dev (2/4) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test ppr dev (3/4) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack production (2/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test integration (2/12) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test prod (3/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test ppr prod (2/4) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test ppr prod (3/4) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack production (5/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack production integration (4/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test prod (5/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack production (1/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test ppr prod (4/4) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack production (4/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test prod (4/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test dev (3/4) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test ppr prod (1/4) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test prod (2/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test dev (2/4) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack production integration (2/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev (4/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test prod (1/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev (3/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev (1/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test dev (4/4) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev (5/5) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test dev (1/4) / build

unused `Vc` that must be used

Check warning on line 196 in packages/next-swc/crates/next-api/src/middleware.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev (2/5) / build

unused `Vc` that must be used
this.project
.emit_all_output_assets(Vc::cell(output_assets))
.await?;
Expand Down
4 changes: 2 additions & 2 deletions packages/next-swc/crates/next-api/src/pages.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1168,7 +1168,7 @@ impl Endpoint for PageEndpoint {
}
};
async move {
let output = self.output();
let output = self.output().await?;
// Must use self.output_assets() instead of output.output_assets() to make it a
// single operation
let output_assets = self.output_assets();
Expand All @@ -1189,7 +1189,7 @@ impl Endpoint for PageEndpoint {
.clone_value();

let node_root = &node_root.await?;
let written_endpoint = match *output.await? {
let written_endpoint = match *output {
PageEndpointOutput::NodeJs { entry_chunk, .. } => WrittenEndpoint::NodeJs {
server_entry_path: node_root
.get_path_to(&*entry_chunk.ident().path().await?)
Expand Down
Loading