Update React from 1df34bdf62 to 20b6f4c0e8 #66711
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Failing test suitesCommit: e2ad4b1
Expand output● app-dir - params hooks compat › should only access search params with useSearchParams Read more about building and testing Next.js in contributing.md.
Expand output● app dir - dynamic error trace › should show the error trace Read more about building and testing Next.js in contributing.md.
Expand output● app-dir static/dynamic handling › should have deterministic etag across revalidates Read more about building and testing Next.js in contributing.md.
Expand output● parallel-routes-revalidation › should handle router.refresh() when called in a slot Read more about building and testing Next.js in contributing.md.
Expand output● shallow-routing › pushState › should support setting data Read more about building and testing Next.js in contributing.md.
Expand output● deterministic build › should have same md5 file across build Read more about building and testing Next.js in contributing.md. |
|
This seems to break due the changes how we schedule work in SSR/RSC but probably due to Next.js bundler issues. We'll prioritise a sync with facebook/react#29811 anyway |
eps1lon
force-pushed
the
sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8
branch
from
27692f0
to
bd9c250
Compare
This was referenced Jun 13, 2024
eps1lon
force-pushed
the
sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8
branch
from
bd9c250
to
03108a9
Compare
eps1lon
changed the base branch from
sebbie/workerd
to
sebbie/06-17-use_react-dom/server.edge_instead_of_.browser_in_edge_runtime
1 task
eps1lon
force-pushed
the
sebbie/06-17-use_react-dom/server.edge_instead_of_.browser_in_edge_runtime
branch
from
47554da
to
dd926ba
Compare
eps1lon
force-pushed
the
sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8
branch
from
03108a9
to
afe437a
Compare
ijjk
added
the
create-next-app
eps1lon
force-pushed
the
sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8
branch
from
6c6fa58
to
061bc85
Compare
ijjk
added
Documentation
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | vercel/next.js sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8 | Change | |
|---|---|---|---|
| buildDuration | 17.6s | 15.2s | N/A |
| buildDurationCached | 8.4s | 7.3s | N/A |
| nodeModulesSize | 359 MB | 349 MB | N/A |
| nextStartRea..uration (ms) | 424ms | 403ms | N/A |
Client Bundles (main, webpack) Overall increase ⚠️
| vercel/next.js canary | vercel/next.js sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8 | Change | |
|---|---|---|---|
| 4006-HASH.js gzip | 36 kB | 36.2 kB | |
| 5305-HASH.js gzip | 5.07 kB | 5.06 kB | N/A |
| 7887.HASH.js gzip | 169 B | 169 B | ✓ |
| a805fa71-HASH.js gzip | 51.7 kB | 51.7 kB | N/A |
| framework-HASH.js gzip | 56.6 kB | 56.6 kB | N/A |
| main-app-HASH.js gzip | 222 B | 219 B | N/A |
| main-HASH.js gzip | 32.2 kB | 32.3 kB | N/A |
| webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
| Overall change | 36.2 kB | 36.4 kB |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8 | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8 | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 193 B | 193 B | ✓ |
| _error-HASH.js gzip | 192 B | 192 B | ✓ |
| amp-HASH.js gzip | 511 B | 511 B | ✓ |
| css-HASH.js gzip | 343 B | 343 B | ✓ |
| dynamic-HASH.js gzip | 2.52 kB | 2.52 kB | N/A |
| edge-ssr-HASH.js gzip | 266 B | 265 B | N/A |
| head-HASH.js gzip | 364 B | 365 B | N/A |
| hooks-HASH.js gzip | 389 B | 392 B | N/A |
| image-HASH.js gzip | 4.27 kB | 4.27 kB | N/A |
| index-HASH.js gzip | 268 B | 266 B | N/A |
| link-HASH.js gzip | 2.69 kB | 2.69 kB | N/A |
| routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
| script-HASH.js gzip | 396 B | 397 B | N/A |
| withRouter-HASH.js gzip | 324 B | 325 B | N/A |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 1.67 kB | 1.67 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8 | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 482 B | 484 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8 | Change | |
|---|---|---|---|
| index.html gzip | 523 B | 522 B | N/A |
| link.html gzip | 538 B | 536 B | N/A |
| withRouter.html gzip | 520 B | 517 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Edge SSR bundle Size Overall increase ⚠️
| vercel/next.js canary | vercel/next.js sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8 | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 126 kB | 126 kB | N/A |
| page.js gzip | 167 kB | 167 kB | |
| Overall change | 167 kB | 167 kB |
Middleware size
| vercel/next.js canary | vercel/next.js sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8 | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 657 B | 658 B | N/A |
| middleware-r..fest.js gzip | 156 B | 156 B | ✓ |
| middleware.js gzip | 29.5 kB | 29.5 kB | N/A |
| edge-runtime..pack.js gzip | 1.03 kB | 1.03 kB | ✓ |
| Overall change | 1.18 kB | 1.18 kB | ✓ |
Next Runtimes Overall increase ⚠️
| vercel/next.js canary | vercel/next.js sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8 | Change | |
|---|---|---|---|
| app-page-exp...dev.js gzip | 184 kB | 184 kB | |
| app-page-exp..prod.js gzip | 112 kB | 113 kB | |
| app-page-tur..prod.js gzip | 123 kB | 124 kB | |
| app-page-tur..prod.js gzip | 119 kB | 120 kB | |
| app-page.run...dev.js gzip | 178 kB | 179 kB | |
| app-page.run..prod.js gzip | 109 kB | 109 kB | |
| app-route-ex...dev.js gzip | 23.4 kB | 23.2 kB | N/A |
| app-route-ex..prod.js gzip | 18.8 kB | 18.8 kB | ✓ |
| app-route-tu..prod.js gzip | 18.8 kB | 18.8 kB | ✓ |
| app-route-tu..prod.js gzip | 18.6 kB | 18.6 kB | N/A |
| app-route.ru...dev.js gzip | 24.6 kB | 24.4 kB | N/A |
| app-route.ru..prod.js gzip | 18.6 kB | 18.6 kB | N/A |
| pages-api-tu..prod.js gzip | 9.55 kB | 9.55 kB | ✓ |
| pages-api.ru...dev.js gzip | 9.82 kB | 9.82 kB | ✓ |
| pages-api.ru..prod.js gzip | 9.55 kB | 9.55 kB | ✓ |
| pages-turbo...prod.js gzip | 21.6 kB | 21.6 kB | ✓ |
| pages.runtim...dev.js gzip | 22.1 kB | 22.2 kB | N/A |
| pages.runtim..prod.js gzip | 21.6 kB | 21.6 kB | ✓ |
| server.runti..prod.js gzip | 51.7 kB | 51.7 kB | ✓ |
| Overall change | 985 kB | 990 kB |
build cache Overall increase ⚠️
| vercel/next.js canary | vercel/next.js sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8 | Change | |
|---|---|---|---|
| 0.pack gzip | 1.66 MB | 1.66 MB | |
| index.pack gzip | 125 kB | 125 kB | |
| Overall change | 1.79 MB | 1.79 MB |
Diff details
Diff for link-HASH.js
@@ -1,7 +1,7 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[4644],
{
- /***/ 4113: /***/ (
+ /***/ 6072: /***/ (
__unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
@@ -9,7 +9,7 @@
(window.__NEXT_P = window.__NEXT_P || []).push([
"/link",
function () {
- return __webpack_require__(4003);
+ return __webpack_require__(6068);
},
]);
if (false) {
@@ -18,7 +18,7 @@
/***/
},
- /***/ 6880: /***/ (module, exports) => {
+ /***/ 8965: /***/ (module, exports) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -110,7 +110,7 @@
/***/
},
- /***/ 806: /***/ (module, exports, __webpack_require__) => {
+ /***/ 9071: /***/ (module, exports, __webpack_require__) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -122,7 +122,7 @@
return getDomainLocale;
},
});
- const _normalizetrailingslash = __webpack_require__(3102);
+ const _normalizetrailingslash = __webpack_require__(4644);
const basePath =
/* unused pure expression or super */ null && (false || "");
function getDomainLocale(path, locale, locales, domainLocales) {
@@ -146,7 +146,7 @@
/***/
},
- /***/ 7429: /***/ (module, exports, __webpack_require__) => {
+ /***/ 3209: /***/ (module, exports, __webpack_require__) => {
"use strict";
/* __next_internal_client_entry_do_not_use__ cjs */
Object.defineProperty(exports, "__esModule", {
@@ -163,17 +163,17 @@
const _react = /*#__PURE__*/ _interop_require_default._(
__webpack_require__(2364)
);
- const _resolvehref = __webpack_require__(2994);
- const _islocalurl = __webpack_require__(1140);
- const _formaturl = __webpack_require__(8297);
- const _utils = __webpack_require__(3939);
- const _addlocale = __webpack_require__(2999);
- const _routercontextsharedruntime = __webpack_require__(9484);
- const _approutercontextsharedruntime = __webpack_require__(3618);
- const _useintersection = __webpack_require__(1779);
- const _getdomainlocale = __webpack_require__(806);
- const _addbasepath = __webpack_require__(275);
- const _routerreducertypes = __webpack_require__(6880);
+ const _resolvehref = __webpack_require__(7563);
+ const _islocalurl = __webpack_require__(8869);
+ const _formaturl = __webpack_require__(4060);
+ const _utils = __webpack_require__(8607);
+ const _addlocale = __webpack_require__(5894);
+ const _routercontextsharedruntime = __webpack_require__(9811);
+ const _approutercontextsharedruntime = __webpack_require__(688);
+ const _useintersection = __webpack_require__(8130);
+ const _getdomainlocale = __webpack_require__(9071);
+ const _addbasepath = __webpack_require__(5692);
+ const _routerreducertypes = __webpack_require__(8965);
const prefetched = new Set();
function prefetch(router, href, as, options, appOptions, isAppRouter) {
if (false) {
@@ -600,7 +600,7 @@
/***/
},
- /***/ 1779: /***/ (module, exports, __webpack_require__) => {
+ /***/ 8130: /***/ (module, exports, __webpack_require__) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -613,7 +613,7 @@
},
});
const _react = __webpack_require__(2364);
- const _requestidlecallback = __webpack_require__(558);
+ const _requestidlecallback = __webpack_require__(1697);
const hasIntersectionObserver =
typeof IntersectionObserver === "function";
const observers = new Map();
@@ -726,7 +726,7 @@
/***/
},
- /***/ 4003: /***/ (
+ /***/ 6068: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -741,7 +741,7 @@
/* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
__webpack_require__(7693);
/* harmony import */ var next_link__WEBPACK_IMPORTED_MODULE_1__ =
- __webpack_require__(3707);
+ __webpack_require__(59);
/* harmony import */ var next_link__WEBPACK_IMPORTED_MODULE_1___default =
/*#__PURE__*/ __webpack_require__.n(
next_link__WEBPACK_IMPORTED_MODULE_1__
@@ -772,12 +772,8 @@
/***/
},
- /***/ 3707: /***/ (
- module,
- __unused_webpack_exports,
- __webpack_require__
- ) => {
- module.exports = __webpack_require__(7429);
+ /***/ 59: /***/ (module, __unused_webpack_exports, __webpack_require__) => {
+ module.exports = __webpack_require__(3209);
/***/
},
@@ -787,7 +783,7 @@
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [2888, 9774, 179], () =>
- __webpack_exec__(4113)
+ __webpack_exec__(6072)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for 4006-HASH.js
Diff too large to display
Diff for a805fa71-HASH.js
Diff too large to display
Diff for app-page-exp..ntime.dev.js
failed to diffDiff for app-page-exp..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page.runtime.dev.js
failed to diffDiff for app-page.runtime.prod.js
Diff too large to display
Diff for app-route-ex..ntime.dev.js
Diff too large to display
Diff for app-route-tu..time.prod.js
Diff too large to display
Diff for app-route.runtime.dev.js
Diff too large to display
Diff for app-route.ru..time.prod.js
Diff too large to display
Diff for pages.runtime.dev.js
Diff too large to display
eps1lon
force-pushed
the
sebbie/06-17-use_react-dom/server.edge_instead_of_.browser_in_edge_runtime
branch
from
dd926ba
to
12cc42f
Compare
eps1lon
changed the base branch from
sebbie/06-17-use_react-dom/server.edge_instead_of_.browser_in_edge_runtime
to
sebbie/06-17-use_next-swc_from_branch_for_pr_size_stats
2 tasks
eps1lon
force-pushed
the
sebbie/06-17-use_next-swc_from_branch_for_pr_size_stats
branch
from
ea9331a
to
55e6749
Compare
eps1lon
force-pushed
the
sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8
branch
from
061bc85
to
0fdb9cd
Compare
eps1lon
force-pushed
the
sebbie/06-17-use_next-swc_from_branch_for_pr_size_stats
branch
from
55e6749
to
52f4af4
Compare
eps1lon
force-pushed
the
sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8
branch
2 times, most recently
from
429ef63
to
78f5413
Compare
eps1lon
force-pushed
the
sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8
branch
from
e076978
to
8e3b1ea
Compare
eps1lon
force-pushed
the
sebbie/06-17-use_next-swc_from_branch_for_pr_size_stats
branch
from
52f4af4
to
91b4d92
Compare
eps1lon
force-pushed
the
sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8
branch
from
8e3b1ea
to
9267fa4
Compare
eps1lon
commented
Jun 18, 2024
| 'Warning: Did not expect server HTML to contain a <%s> in <%s>.%s', | ||
| 'Cannot render a sync or defer <script> outside the main document without knowing its order. Try adding async="" or moving it into the root <head> tag.%s', | ||
| 'In HTML, %s cannot be a child of <%s>.%s\nThis will cause a hydration error.%s', | ||
| 'In HTML, %s cannot be a descendant of <%s>.\nThis will cause a hydration error.%s', |
There was a problem hiding this comment.
Need to double check if these work as well i.e. I'm not sure if the last placeholder is the component stack and if we still inject it.
Base automatically changed from
sebbie/06-17-use_next-swc_from_branch_for_pr_size_stats
to
sebbie/06-17-use_react-dom/server.edge_instead_of_.browser_in_edge_runtime
June 18, 2024 13:09
ijjk
pushed a commit
that referenced
this pull request
Jun 18, 2024
Currently, PR stats are always downloading published binaries: > cd /tmp/next-statsJoJEbE/stats-app && NEXT_TELEMETRY_DISABLED=1 pnpm next build > [...] > Downloading swc package @next/swc-linux-x64-gnu... -- https://github.com/vercel/next.js/actions/runs/9505097022/job/26199227309#step:7:1713 ## test plan - [x] Makes #66711 go green - [x] `GIT_ROOT_DIR=https://github.com/ GITHUB_REPOSITORY=vercel/next.js GITHUB_REF=sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8 GITHUB_ACTION=synchronize node .github/actions/next-stats-action/src/index.js` completes `pnpm build` (but fails afterwards locally which is expected)
Base automatically changed from
sebbie/06-17-use_react-dom/server.edge_instead_of_.browser_in_edge_runtime
to
canary
June 19, 2024 09:41
eps1lon
force-pushed
the
sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8
branch
from
74a0183
to
8879185
Compare
eps1lon
changed the base branch from
canary
to
sebbie/06-19-improve_hydration_error_overlay_coverage
This was referenced Jun 19, 2024
Merged
eps1lon
force-pushed
the
sebbie/06-19-improve_hydration_error_overlay_coverage
branch
from
dc921b9
to
1d0008d
Compare
eps1lon
force-pushed
the
sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8
branch
from
8879185
to
333a2a0
Compare
eps1lon
force-pushed
the
sebbie/06-19-improve_hydration_error_overlay_coverage
branch
from
1d0008d
to
45f1b99
Compare
eps1lon
force-pushed
the
sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8
branch
from
333a2a0
to
ff3bdab
Compare
eps1lon
force-pushed
the
sebbie/06-19-improve_hydration_error_overlay_coverage
branch
from
45f1b99
to
329cd52
Compare
eps1lon
force-pushed
the
sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8
branch
from
ff3bdab
to
1167335
Compare
Base automatically changed from
sebbie/06-19-improve_hydration_error_overlay_coverage
to
canary
June 20, 2024 09:39
eps1lon
force-pushed
the
sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8
branch
from
1167335
to
e5712c6
Compare
We treated react-is separately in a separate task but it really should be handled the same as React, ReactDOm etc. It is still missing a vendored version of the experimental release channel. We only use `isValidElementType` though and that method needs to move to the renderer anyway. I'd rather prioritize the renderer work instead of more aliasing effort in our bundler.
Latest Canary is not compatible with published Next.js.
eps1lon
force-pushed
the
sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8
branch
from
e5712c6
to
e2ad4b1
Compare
eps1lon
changed the base branch from
canary
to
sebbie/06-25-make_synced_react-is_version_more_obvious
This was referenced Jun 25, 2024
Closed
Base automatically changed from
sebbie/06-25-make_synced_react-is_version_more_obvious
to
canary
June 26, 2024 09:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diff facebook/react@ 1df34bdf62...20b6f4c0e8
React upstream changes
use-sync-external-store/shimfacebook/react#29868refprop as a ref facebook/react#29834useReduceris non-reactive facebook/react#29705ipdependency update for CVE-2024-29415 facebook/react#29725