Example/update blog starter #66926
Merged
Example/update blog starter #66926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank1513
requested review from
ismaelrumzan and
timeyoutakeit
and removed request for
a team
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
mayank1513
force-pushed
the
example/update-blog-starter
branch
3 times, most recently
from
425a4aa
to
52b7ed5
Compare
|
@mayank1513 Let me know when this ready for |
I think this is ready for review/merge. |
|
@mayank1513 Can you update the packages as well (e.g., latest |
|
Done sir! Thank you for pointing out. |
- update classes for dark mode for footer and alert - use classnames lib for adding multiple classes to layout
- Add ServerTarget and Core components to layout - That's all that is required to get a working darkmode with Server Component sync
- Add Switch component from nextjs-darkmode - Add styles for the Switch component
- No cookies
…uired for this example
- Keeping 2 components in same file for clarity and readability
and set next to latest
mayank1513
force-pushed
the
example/update-blog-starter
branch
from
3469801
to
82d6e83
Compare
samcx
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updated blog-starter example to support dark theme. Also added a button to switch modes (User preference).
→ User can opt for dark / light / system mode
→ Mode is persisted using localStorage
→ Mode is also synced across browsing contexts
→ No FOUC (Flash of Unstyled Content)
→ Full SSG
→ No additional dependency
Why?
Now that dark mode is a first-class feature of many operating systems, it’s becoming more and more common to design a dark version of your website to go along with the default design.
How?
dark:modifier