Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show both internal and shared state managment in example. #7312

Merged
merged 13 commits into from
May 23, 2019

Commits on May 12, 2019

  1. Show both internal and shared state managment in example.

    I pointed someone at this example and they were confused by the
    shared state example.  To help with their confusion I updated
    the example to show both shared and internal component state.
    
    There is an issue with the `IncrementGlobal` action that I've so
    far been unable to sort out.  Upon first load, if you click the `Add`
    button beneath the `Persistan Count` display then the `IncrementGlobal`
    action seems to be dispatched twice on a single click.  Hopefully,
    someone will be able to point out my, likely, very dumb error.
    Nathan Anthony Sculli authored and Nathan Anthony Sculli committed May 12, 2019
    Configuration menu
    Copy the full SHA
    837cb45 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    641e0e2 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2019

  1. Merge branch 'canary' of https://github.com/zeit/next.js into rework-…

    …fix-for-issue-5049
    scull7 committed May 14, 2019
    Configuration menu
    Copy the full SHA
    c34decf View commit details
    Browse the repository at this point in the history
  2. Merge branch 'rework-fix-for-issue-5049' of github.com:scull7/next.js…

    … into rework-fix-for-issue-5049
    scull7 committed May 14, 2019
    Configuration menu
    Copy the full SHA
    9a83571 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2019

  1. Add a global state custom hook.

    Adding a custom hook to track the global state eliminates the
    double increment on first click issue and leads to all of the
    reference tracking being in the GlobalCount module.
    
    Also, this does not require the use of any odd concept within
    the components themselves.
    scull7 committed May 15, 2019
    Configuration menu
    Copy the full SHA
    6326057 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca8fbfa View commit details
    Browse the repository at this point in the history
  3. Remove outdated comments

    scull7 committed May 15, 2019
    Configuration menu
    Copy the full SHA
    c250e97 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    03e7282 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bf448b2 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2019

  1. Revert "Provide example using context API"

    This reverts commit 03e7282.
    arecvlohe committed May 16, 2019
    Configuration menu
    Copy the full SHA
    ea84168 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'rework-fix-for-issue-5049' of github.com:scull7/next.js…

    … into rework-fix-for-issue-5049
    arecvlohe committed May 16, 2019
    Configuration menu
    Copy the full SHA
    2bd23b5 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2019

  1. Configuration menu
    Copy the full SHA
    d9af316 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2019

  1. Configuration menu
    Copy the full SHA
    8a277c4 View commit details
    Browse the repository at this point in the history