Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strictly match next/dist in externals configuration #9956

Merged
merged 2 commits into from
Jan 6, 2020
Merged

Strictly match next/dist in externals configuration #9956

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7289e1f
Allow libs that ends with `next/dist` such as `i18next`, `next-i18nex…
felixmosh Jan 5, 2020
ae44d77
Merge branch 'canary' into fix-9022
Timer Jan 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next/build/webpack-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ export default async function getBaseWebpackConfig(
// Default pages have to be transpiled
if (
!res.match(/next[/\\]dist[/\\]next-server[/\\]/) &&
felixmosh marked this conversation as resolved.
Show resolved Hide resolved
(res.match(/next[/\\]dist[/\\]/) ||
(res.match(/[/\\]next[/\\]dist[/\\]/) ||
res.match(/node_modules[/\\]@babel[/\\]runtime[/\\]/) ||
res.match(/node_modules[/\\]@babel[/\\]runtime-corejs2[/\\]/))
) {
Expand Down