Skip to content

Commit

Permalink
fix: add special case for sharp@0.33.0 optional dependencies (#372)
Browse files Browse the repository at this point in the history
- Fixes #371

Additionally:
- Replaced `yarn` with `npm` (sharp requires it)
- Updated `@ffmpeg-installer/ffmpeg`, `oracledb`, `sharp` to versions
which support Apple Silicon
- Disabled `microtime-node-gyp` test on Apple Silicon
- Fixed expected output for some tests which implicitly upgraded dep
versions

I also skipped a few ECMAScript Next tests because they currently fail.

At first I thought this must be a regression since the tests were
passing on main (head is 285c930).
However, the tests were always failing and jest was silently succeeding.
Regenerating the lockfile, implicitly upgraded jest from `27.4.5` to
`27.5.1` (due to the `^` prefix) and this included a fix that is now
surfacing the error.

I also converted this file from `jest` to `node:test` just to confirm
that it also fails on main.

Since these tests are Stage 2 features, likely no one has noticed they
don't work because no JS runtime implements them.

---------

Co-authored-by: Ethan Arrowood <ethan@arrowood.dev>
Co-authored-by: Chris Barber <chris.barber@vercel.com>
Co-authored-by: Chris Barber <chris@cb1inc.com>
  • Loading branch information
4 people committed Jan 2, 2024
1 parent 285c930 commit 9470e71
Show file tree
Hide file tree
Showing 14 changed files with 33,972 additions and 17,386 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,13 @@ jobs:
- name: Prepare Install (if applicable)
run: node prepare-install.js
- name: Install Dependencies
run: yarn install --network-timeout 1000000
run: npm install
- name: Build
run: yarn build
run: npm run build
- name: Run Tests
env:
BULL_REDIS_CONNECTION: ${{ (matrix.os == 'ubuntu-latest') && 'redis://127.0.0.1:6379/0' || '' }}
run: yarn test-verbose
run: npm run test-verbose
- name: Maybe Release
if: matrix.os == 'ubuntu-latest' && matrix.node == 18 && github.event_name == 'push' && github.ref == 'refs/heads/main'
env:
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ out
coverage
test/**/dist
test/**/actual.js
yarn.lock
pnpm-lock.yaml
Loading

0 comments on commit 9470e71

Please sign in to comment.