Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for node-gyp-build #1

Closed
guybedford opened this issue Jul 6, 2019 · 2 comments
Closed

Add support for node-gyp-build #1

guybedford opened this issue Jul 6, 2019 · 2 comments

Comments

@guybedford
Copy link
Contributor

See https://www.npmjs.com/package/node-gyp-build.
@styfle styfle mentioned this issue Aug 27, 2019
Closed
@styfle styfle changed the title node-gyp-build support Add support for node-gyp-build Aug 27, 2019
@styfle
Copy link
Member

styfle commented Apr 30, 2020

@guybedford Looks like node-gyp-build is used here: https://github.com/zeit/node-file-trace/blob/d7410632a5aadc1c461b59d39ce761dfbb95cf48/src/analyze.js#L99-L101

Anything else need to be implemented to support node-gyp-build or can we close this?

@guybedford
Copy link
Contributor Author

Yes this was added with the Node.js 12 CI fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@styfle @guybedford