Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for argon2 #45

Closed
styfle opened this issue Aug 15, 2019 · 6 comments · Fixed by #53
Closed

Add support for argon2 #45

styfle opened this issue Aug 15, 2019 · 6 comments · Fixed by #53

Comments

@styfle
Copy link
Member

styfle commented Aug 15, 2019

This integration test fails:

const argon2 = require('argon2');
console.log('argon is ' + typeof argon2);

Error

/private/var/folders/v7/6kzxdgb93x328tk9pg633s200000gn/T/node-file-trace-2963026860021942/node_modules/node-gyp-build/index.js:56
  throw new Error('No native build was found for ' + target)
  ^

Error: No native build was found for platform=darwin arch=x64 runtime=node abi=64 uv=1 libc=glibc
    at Function.load.path (/private/var/folders/v7/6kzxdgb93x328tk9pg633s200000gn/T/node-file-trace-2963026860021942/node_modules/node-gyp-build/index.js:56:9)
    at load (/private/var/folders/v7/6kzxdgb93x328tk9pg633s200000gn/T/node-file-trace-2963026860021942/node_modules/node-gyp-build/index.js:20:30)
    at Object.<anonymous> (/private/var/folders/v7/6kzxdgb93x328tk9pg633s200000gn/T/node-file-trace-2963026860021942/node_modules/argon2/argon2.js:5:81)
    at Module._compile (internal/modules/cjs/loader.js:776:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:787:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:690:17)
    at require (internal/modules/cjs/helpers.js:25:18)

Related to https://github.com/zeit/now-builders/issues/929

This is likely an issue with argon2's dependency node-gyp-build (related to #1) which will likely have to be special cased.

@hoangvvo
Copy link

Hey @styfle, any ETA for this? Been trying to deployed with Now for a month now... Would love to see it available soon. Thank you for your work.

@styfle
Copy link
Member Author

styfle commented Aug 20, 2019

Fixed in #53 and shipping to @now/node in this PR https://github.com/zeit/now-builders/pull/947

@nohren
Copy link

nohren commented Apr 9, 2021

This issue is still a problem in vercel. We got a cannot find module argon2 in vercel functions tab.

@styfle
Copy link
Member Author

styfle commented Apr 9, 2021

The previous fix was for argon 0.24.0 so maybe something changed in a newer version.

Can you create a new issue with the version of argon you're using?

@nohren
Copy link

nohren commented Apr 9, 2021

Done #183

@bradley-us
Copy link

Returning to "next": "^14.1.1" version worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants