Webpack wrappers - string ids and namespaces #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
Jun 10, 2020
| else if (parent.arguments && parent.arguments.some(arg => arg === node)) | ||
| } | ||
| else if (parent.arguments && parent.arguments.some(arg => arg === node)) { | ||
| delete parent.scope.declarations[node.id]; |
There was a problem hiding this comment.
@guybedford This is breaking Next.js tests because parent.scope.declarations is undefined.
Why is the delete necessary? Can it be guarded with if (parent.scope.declarations)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the support for webpack wrapper parsing to handle string ids in the Webpack module registry, as well as webpack ES module namespace object handling in determining full analysis of properties of those namespaces to the external when it is an external reference.
Webpack uses a
__webpack_require__.n(obj)pattern here which is specifically detected and inlined in a way that can be used by the pure static analysis in further processing steps.