Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trailing slash handling #128

Merged
merged 7 commits into from Jun 27, 2020
Merged

Fix trailing slash handling #128

merged 7 commits into from Jun 27, 2020

Conversation

guybedford
Copy link
Contributor

This fixes up the resolution of specifiers with a trailing slash to ensure they skip file resolution when there exists a file by the same name.

Fixes #127

src/resolve-dependency.js Outdated Show resolved Hide resolved
src/resolve-dependency.js Outdated Show resolved Hide resolved
Co-authored-by: Steven <steven@ceriously.com>
@guybedford
Copy link
Contributor Author

Test failure here seems like a flake?

src/resolve-dependency.js Outdated Show resolved Hide resolved
guybedford and others added 4 commits June 26, 2020 17:24
src/resolve-dependency.js Outdated Show resolved Hide resolved
Co-authored-by: Steven <steven@ceriously.com>
@styfle styfle added the automerge Automatically merge PR once checks pass label Jun 27, 2020
@kodiakhq kodiakhq bot merged commit 426edaa into master Jun 27, 2020
@kodiakhq kodiakhq bot deleted the fix-trailing-slash branch June 27, 2020 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't play well with older version of http-party/node-http-proxy
2 participants