feat: Add support for Node.js 16 #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #243 +/- ##
==========================================
- Coverage 81.14% 80.72% -0.42%
==========================================
Files 13 13
Lines 1453 1453
Branches 539 539
==========================================
- Hits 1179 1173 -6
- Misses 108 116 +8
+ Partials 166 164 -2
Continue to review full report at Codecov.
|
ijjk
approved these changes
Dec 22, 2021
ijjk
reviewed
Dec 22, 2021
| require("acorn-private-class-elements") | ||
| //require("acorn-class-fields"), | ||
| //require("acorn-static-class-features"), | ||
| //require("acorn-private-class-elements") |
There was a problem hiding this comment.
Should we fully remove these lines as tests are passing with them disabled?
There was a problem hiding this comment.
I'm going to do a follow up PR to make sure we support all Node.js 16 features and therefore plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Node.js 16 LTS by bumping a few dependencies.
We also dropped Node.js 12 from CI but support is still there since tsconfig.json is unmodified.
In the future, we can update tsconfig.json target to es2020 once Node.js 12 reaches EOL.