Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node-gyp-build binary locating in different versions #286

Merged
merged 8 commits into from
May 18, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 18, 2022

Instead of relying on our installed node-gyp-build version, this updates to use the installed version by default and then falls back to our installed version if the default one fails. This fixes a case noticed by a user where packages using node-gyp-build at v3 fails to locate the binaries correctly, specifically this was noticed on the microtime package.

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #286 (275fa18) into main (37830e7) will decrease coverage by 0.09%.
The diff coverage is 50.00%.

❗ Current head 275fa18 differs from pull request most recent head 5a09bdb. Consider uploading reports for the commit 5a09bdb to get more accurate results

@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   80.44%   80.34%   -0.10%     
==========================================
  Files          13       13              
  Lines        1483     1486       +3     
  Branches      555      555              
==========================================
+ Hits         1193     1194       +1     
- Misses        120      122       +2     
  Partials      170      170              
Impacted Files Coverage Δ
src/analyze.ts 86.21% <50.00%> (-0.38%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ijjk ijjk marked this pull request as ready for review May 18, 2022 02:17
@ijjk ijjk requested a review from styfle as a code owner May 18, 2022 02:17
@ijjk ijjk changed the title Fix node-gyp-build v3 binary locating Fix node-gyp-build binary locating in different versions May 18, 2022
@styfle styfle changed the title Fix node-gyp-build binary locating in different versions fix: node-gyp-build binary locating in different versions May 18, 2022
@ijjk ijjk requested a review from styfle May 18, 2022 16:15
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants