-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: node-gyp-build binary locating in different versions #286
Conversation
Codecov Report
@@ Coverage Diff @@
## main #286 +/- ##
==========================================
- Coverage 80.44% 80.34% -0.10%
==========================================
Files 13 13
Lines 1483 1486 +3
Branches 555 555
==========================================
+ Hits 1193 1194 +1
- Misses 120 122 +2
Partials 170 170
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Instead of relying on our installed
node-gyp-build
version, this updates to use the installed version by default and then falls back to our installed version if the default one fails. This fixes a case noticed by a user where packages usingnode-gyp-build
atv3
fails to locate the binaries correctly, specifically this was noticed on themicrotime
package.