fix: add shiki to special case list #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
souporserious
changed the title
styfle
reviewed
Oct 11, 2023
styfle
reviewed
Oct 11, 2023
|
@styfle thank you for the feedback! I updated the input/output files to reflect the real-world usage. However, for some reason I'm still having trouble with tests not passing. |
|
@souporserious I pushed a change which should fix it |
|
@styfle woot, that looks great, thank you! 🙏 I can't tell why the test is still failing, but I'm wondering if we need to account for themes as well since I believe |
styfle
approved these changes
Oct 12, 2023
|
🎉 This PR is included in version 0.24.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds shiki to the special case list so grammars and themes will be traced and loaded correctly when deploying.