Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: node-gyp-build for @datadog/pprof #419

Merged
merged 3 commits into from
May 16, 2024
Merged

fix: node-gyp-build for @datadog/pprof #419

merged 3 commits into from
May 16, 2024

Conversation

styfle
Copy link
Member

@styfle styfle commented May 16, 2024 •
edited

@styfle styfle marked this pull request as ready for review May 16, 2024 03:13
@styfle styfle requested a review from ijjk as a code owner May 16, 2024 03:13
@styfle styfle requested a review from TooTallNate May 16, 2024 03:14
@styfle styfle mentioned this pull request May 16, 2024
Closed
@styfle styfle enabled auto-merge (squash) May 16, 2024 03:15
EndangeredMassa
EndangeredMassa approved these changes May 16, 2024
View reviewed changes
Copy link

@EndangeredMassa EndangeredMassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the deepest context on how this works, but the changes look good to me.

@styfle styfle merged commit db6c65a into main May 16, 2024
10 checks passed
@styfle styfle deleted the styfle/fix-datadog-pprof branch May 16, 2024 14:38
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.27.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@styfle styfle mentioned this pull request May 16, 2024
Merged
styfle added a commit to vercel/next.js that referenced this pull request May 16, 2024
@styfle
fix: bump nft@0.27.1 (#65854)
780e77b 
- vercel/nft#415
([e001d05](vercel/nft@e001d05))
- vercel/nft#417
([ddc5cba](vercel/nft@ddc5cba))
- vercel/nft#419
([db6c65a](vercel/nft@db6c65a))
panteliselef pushed a commit to panteliselef/next.js that referenced this pull request May 20, 2024
@styfle @panteliselef
fix: bump nft@0.27.1 (vercel#65854)
eb1246e 
- vercel/nft#415
([e001d05](vercel/nft@e001d05))
- vercel/nft#417
([ddc5cba](vercel/nft@ddc5cba))
- vercel/nft#419
([db6c65a](vercel/nft@db6c65a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EndangeredMassa EndangeredMassa EndangeredMassa approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@TooTallNate TooTallNate Awaiting requested review from TooTallNate

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for @datadog/pprof
2 participants
@styfle @EndangeredMassa