Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

--loglevel param #48

Closed
simast opened this issue May 1, 2017 · 4 comments
Closed

--loglevel param #48

simast opened this issue May 1, 2017 · 4 comments
Labels

Comments

@simast
Copy link

simast commented May 1, 2017

Old enclose had --loglevel param where you could have disabled warning level log messages for example. I can't seem to find this in the new version. Was it removed for some reason?

In some places I am not using string literals with require calls, but including those files using scripts config option. Hence those warnings aren't really interesting to me and I am well aware of the functionality.

@igorklopov
Copy link
Contributor

Hi, Simas! I discourage you disable all warnings, because newly introduced bug may come unnoticed. If you really want to mute them, provide may-exclude per occurence.
https://github.com/zeit/now-cli/blob/5.0.0/bin/now.js#L114
I will add may-exculde description soon to readme.

@simast
Copy link
Author

simast commented May 2, 2017

Hi Igor!

Thanks for bringing enclose back from the dead (and with Node 7+ support)!

I can's say I am a huge fan of extending and monkey-patching built-in require with such a custom functionality and adding pkg specific arguments all over your codebase just to ignore those warnings. There is also an issue that at some point Node.js will decide to implement their own second require param for some reason.

Anyway, if you think there is a good reason not to include loglevel param - I will have to live with those warnings.

@igorklopov
Copy link
Contributor

Is it your code that causes warnings? Or code of npm dependencies? If so, name those npm deps please.

@simast
Copy link
Author

simast commented May 8, 2017

Yes, my code is causing those warnings. Think about functionality that would load all .js files in a directory (plugins and such).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants