add workflow for GitHub Actions #1073
Conversation
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test |
There was a problem hiding this comment.
I would replace all these lines with a single run: |, also did you try to keep only the npm install and npm test commands?
There was a problem hiding this comment.
Maybe consolidate them into Install dependencies step.
npm install and npm test should remain separate steps.
|
Also remember to replace the badge in readme with the workflow badge |
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} |
There was a problem hiding this comment.
Here I see a matrix but there is no one specified in this job
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| node-version: [10.x, 14.x] |
There was a problem hiding this comment.
Why don't include 12.x too?
There was a problem hiding this comment.
Yes. And, add Current (15.x) as well. It is important for this project to track the latest developments of Node.js.
| - run: sudo apt-get update -qq | ||
| - run: sudo apt-get -yq --no-install-suggests --no-install-recommends --force-yes install gcc-4.8 g++-4.8 | ||
| - run: sudo apt-get -yq --no-install-suggests --no-install-recommends --force-yes install libavahi-compat-libdnssd-dev # npm install mdns | ||
| - run: export CXX="g++-4.8" CC="gcc-4.8" |
There was a problem hiding this comment.
GCC 4.8? Not acceptable in 2021.
Why not simply use build-essential?
I would also like to see a workflow for the latest GCC and Clang.**
** I can do this myself later, though.
|
Thanks for this! Looking great - agree with the feedback above 🚀 |
|
Supersided by #1074 |
|
Thank you guy, let's close this one. |
No description provided.