Support mkdir at mountpoints #1120
Conversation
| function mkdirInSnapshot(path_, cb) { | ||
| var cb2 = cb || rethrow; | ||
| return cb2( | ||
| new Error('Cannot mkdir in a snapshot. Try mountpoints instead.') |
There was a problem hiding this comment.
Is there a better error for here?
There was a problem hiding this comment.
I would instead change the name of the method in something more user friendly, something like mkdirThrowInSnapshot
There was a problem hiding this comment.
I went with mkdirFailInSnapshot because it doesn't throw if a callback is provided to the async method, but it still fails.
|
Test added! I named it with the PR number. Let me know if it should be something different. |
|
Hmm, this had the same pnpm failure as #1121 |
|
Seems that the problem is node version, strange them were not failing before... @erossignon could you fix those tests please? |
|
Let me provide a patch for the pnpm issue... |
|
please merge #1122 first |
|
This can be merged once check pass |
|
@leerob can we merge this? |
I'm working on a CLI tool that bundles some code, but then mirrors the directory structure out to the filesystem. This is done using mountpoints and this patch that allows
fs.mkdirto apply to them.