Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

ldid: explicitly mark signature as adhoc #1393

Merged
merged 1 commit into from Nov 12, 2021
Merged

ldid: explicitly mark signature as adhoc #1393

merged 1 commit into from Nov 12, 2021

Conversation

asdfugil
Copy link
Contributor

No description provided.

@jesec
Copy link
Contributor

jesec commented Nov 12, 2021

Can you explain why this is neccessary?

@asdfugil
Copy link
Contributor Author

asdfugil commented Nov 12, 2021

it is needed for macOS Monterey (arm64)

Copy link
Contributor

@jesec jesec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am able to run the binary (produced with the current flags) on macOS Monterey. That is, this PR is not really neccessary.

Executable=/Users/jc/Sources/pkg/1
Identifier=pkg-macos
Format=Mach-O thin (arm64)
CodeDirectory v=20400 size=389954 flags=0x0(none) hashes=12181+2 location=embedded
./1: no signature
Info.plist=not bound
TeamIdentifier=not set
Sealed Resources=none
Internal requirements count=1 size=128

Nonetheless, I am happy to make the result closer to the codesign utility.

@asdfugil
Copy link
Contributor Author

sorry i mixed it up with iOS 15 (which we don't target), and that doesn't allow JIT anyways so this really isn't necessary

@jesec jesec merged commit b63df87 into vercel:main Nov 12, 2021
@nathan818fr
Copy link

What version of ldid are you using?
There is no -C option: https://github.com/xerub/ldid/blob/master/ldid.cpp
Since ldid terminates silently in case of unknown options, this change only skips the code-signing.

@jesec
Copy link
Contributor

jesec commented Feb 19, 2022

https://github.com/jesec/ldid-static

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants