Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

dictionary: bunyan #154

Merged
merged 4 commits into from
Jul 1, 2017
Merged

dictionary: bunyan #154

merged 4 commits into from
Jul 1, 2017

Conversation

weirongxu
Copy link
Contributor

fix bunyan dynamic require

@igorklopov
Copy link
Contributor

igorklopov commented Jun 30, 2017

Is it only to remove a warnings? Does it break at run time without dict?
Try as require('mv', 'may-exclude');

@weirongxu
Copy link
Contributor Author

@igorklopov Its break at run time when use rotating-file steam.

const logger = require('bunyan').createLogger({
  name: 'pkg',
  streams: [{
    type: 'rotating-file',
    path: 'pkg.log',
    level: 'info',
  }]
})

@weirongxu
Copy link
Contributor Author

@igorklopov I try to add require('mv', 'may-exclude'), Its work very well.

@igorklopov
Copy link
Contributor

require('mv', 'may-exclude'); still absent in changes. Add it please

@igorklopov
Copy link
Contributor

Oh, sorry, now i get the problem. Please undo may-exclude. It is not needed really. And then i merge 👍

@igorklopov igorklopov merged commit cf076de into vercel:master Jul 1, 2017
xdevs23 pushed a commit to xdevs23/pkg that referenced this pull request Jul 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants