Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

feat(parser): handle template literal without expressions #981

Merged
merged 1 commit into from
Mar 30, 2021
Merged

feat(parser): handle template literal without expressions #981

merged 1 commit into from
Mar 30, 2021

Conversation

DevSide
Copy link
Contributor

@DevSide DevSide commented Oct 10, 2020 •
edited

This makes the parser handle TemplateLiteral without expressions as Literal.

require(`module`)
require.resolve(`module`)
path.join(__dirname, `./file`)

Dynamic import(`module`) is not treated in this PR.

@DevSide DevSide force-pushed the handle-TemplatelLiteral branch 2 times, most recently from c9830e3 to 7ff93f5 Compare October 10, 2020 12:34
@DevSide DevSide changed the title feat(parser): handle template literal without arguments feat(parser): handle template literal without expressions Oct 10, 2020
@DevSide DevSide force-pushed the handle-TemplatelLiteral branch 4 times, most recently from af027fe to 0558266 Compare October 13, 2020 08:25
@leerob
Copy link
Member

leerob commented Mar 25, 2021

Is there an existing issue for this?

@DevSide
Copy link
Contributor Author

DevSide commented Mar 25, 2021

No, I didn't create an issue, i just fixed it.

@robertsLando
Copy link
Contributor

robertsLando commented Mar 26, 2021 •
edited

@DevSide Could you fix merge conflicts please? Fixes are ok, can be merged once conflicts are fixed and tests pass

@robertsLando robertsLando added the ok to merge PR changes are ok label Mar 26, 2021
@robertsLando robertsLando mentioned this pull request Mar 26, 2021
Merged
leerob
leerob approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! 🙏

@leerob
Copy link
Member

leerob commented Mar 26, 2021

Looks like two small merge conflicts, would you mind addressing and then we can merge?

@DevSide
Copy link
Contributor Author

DevSide commented Mar 30, 2021

It should be good to merge 😃

robertsLando
robertsLando approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando merged commit 79cca54 into vercel:master Mar 30, 2021
@DevSide DevSide deleted the handle-TemplatelLiteral branch March 31, 2021 08:43
@robertsLando robertsLando mentioned this pull request Apr 7, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hipstersmoothie hipstersmoothie hipstersmoothie approved these changes

@leerob leerob leerob approved these changes

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
ok to merge PR changes are ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DevSide @leerob @robertsLando @hipstersmoothie