New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to TypeScript #15
Conversation
# Conflicts: # package-lock.json # package.json
@NuroDev I resolved some merged conflicts but I'm currently running into the Will look into this more next week but if you wanna take a stab at it in the meantime feel free to do so! |
# Conflicts: # pages/_middleware.js # pages/app/post/[id]/index.tsx # pages/app/post/[id]/settings.tsx
@steven-tey I've had a look into this Prisma issue a bit more and, as the error implies, the Prisma client instance is somewhere being leaked into the browser, which is not to be expected. I've not been able to track down the exact cause but tracked down the issue to the following commit: NuroDev@ccf348a. Seems at some point during that |
Amazing! Thank you so much. |
Thanks for the help @Rocinante89, merged that change that actually was needed. This should now be fixed if anyone wants to give it a test 🙂 |
hi there, cheers, |
Not as far as I am aware. Just waiting on final review & approval from someone at the @vercel team so we can get this merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been a work in progress for a while, thanks a lot for your hard work @NuroDev! I just got around to reviewing this fully and I'm gonna merge this to main now! 🚀
What
This PR migrates the code base to using TypeScript, as recommended by @leerob in #3.
It also includes a number of other changes, including the following:
lib/fetcher
)@/types
import aliastypes/
directory for all custom typesconsole.log
'sjsconfig.json
domain
endpointslib/
directory