Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the lang="ja" attribute #170

Closed
shuding opened this issue Oct 11, 2022 · 0 comments · Fixed by #260
Closed

Support the lang="ja" attribute #170

shuding opened this issue Oct 11, 2022 · 0 comments · Fixed by #260
Labels
enhancement New feature or request

Comments

@shuding
Copy link
Member

shuding commented Oct 11, 2022

Feature Request

Description

Additional Context

https://heistak.github.io/your-code-displays-japanese-wrong/

https://twitter.com/mandel59/status/1579647588936355841
@shuding shuding added the enhancement New feature or request label Oct 11, 2022
@LuciNyan LuciNyan mentioned this issue Oct 25, 2022
Merged
shuding pushed a commit that referenced this issue Jan 7, 2023
@LuciNyan
feat: support the lang="ja" attribute (#260)
8c348f9 
### Description
Support the `lang="ja"` attribute.

1. For those words with the same Unicode Code Point but different glyphs
(in different languages), different glyphs need to be displayed
according to the lang attribute. Such as `刃直海角骨入`.
2. Chinese characters (e.g. `樱`) can also be displayed correctly
(through safe fallback) under the label with lang="ja" set.
3. Japenese kanji (e.g. `桜`) can also be displayed correctly (through
safe fallback) under the label with lang="zh" set.

Because we can't distinguish Chinese hanzi and Japanese kanji by regex,
this PR uses some tricky codes when implementing the above feature. So
I'm wondering if I need to do this. Are there two other straightforward
implementations below that might look better?
1. Give up displaying hanzi when the user sets lang="ja".
2. We download all possible languages ​​when we need to download
hanzi(kanji).

What do you think? 🤔

### Additional
<img width="1439" alt="image"
src="https://user-images.githubusercontent.com/22126563/199142248-05487041-6086-493c-a472-34af5aa75c64.png">

Closes: #170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support the lang="ja" attribute LuciNyan/satori
1 participant
@shuding