Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable symlinks by default #84

Merged
merged 2 commits into from Apr 3, 2019
Merged

Disable symlinks by default #84

merged 2 commits into from Apr 3, 2019

Conversation

leo
Copy link
Contributor

@leo leo commented Apr 2, 2019

In order to prevent potential security issues, the team has decided to disable symlinks by default.

To enable them, you can define the symlinks option:

{
   "symlinks": true
}

Furthermore, this pull request also adds a new handler for fs.realpath, which is responsible for resolving the target of symlinks if they are enabled.

@leo leo added the enhancement New feature or request label Apr 2, 2019
@leo leo requested a review from OlliV April 2, 2019 22:29
@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #84   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         320    324    +4     
=====================================
+ Hits          320    324    +4
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1368bf...438e4e9. Read the comment docs.

@leo leo merged commit 360d3df into master Apr 3, 2019
@leo leo deleted the symlink branch April 3, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants