Open local address in default browser #198
Conversation
|
👍 I'd rather call it |
|
Yeah 😀. It should be |
|
@leo I have changed |
lib/listening.js
Outdated
| @@ -67,6 +68,13 @@ module.exports = coroutine(function*(server, current, inUse, clipboard) { | |||
| } catch (err) {} | |||
| } | |||
|
|
|||
| if(open) { | |||
There was a problem hiding this comment.
Please add a space before the (
lib/listening.js
Outdated
| if(open) { | ||
| try { | ||
| opn(localURL) | ||
| message += `\n\n${chalk.grey('Local address has opened in browser!')}` |
There was a problem hiding this comment.
Let's not show any additional messages in the terminal!
bin/serve.js
Outdated
| @@ -108,7 +109,7 @@ detect(port).then(open => { | |||
| server.listen( | |||
| port, | |||
| coroutine(function*() { | |||
| yield listening(server, current, inUse, flags.noClipboard !== true) | |||
| yield listening(server, current, inUse, flags.noClipboard !== true, flags.open === true) | |||
There was a problem hiding this comment.
Why the comparison? flags.open should be enough
|
@leo Updated all the changes you asked. |
bin/serve.js
Outdated
| @@ -50,7 +50,7 @@ args | |||
| ) | |||
| .option('silent', `Don't log anything to the console`) | |||
| .option('no-clipboard', `Don't copy address to clipboard`, false) | |||
|
|
|||
| .option('open', `Open local address in browser`, false) | |||
There was a problem hiding this comment.
Use ' instead of ` here, please
There was a problem hiding this comment.
should I change it for silent and no-clipboard also?
There was a problem hiding this comment.
@webtaculars No, because they have a ' in the value.
There was a problem hiding this comment.
we can escape it using backslash
There was a problem hiding this comment.
Yes, but prettier might revert that. Try it!
|
Thanks! ✌️ |
Open local address in default browser by using option --local.
serve --localEDIT
Command is now
serve --open