feat: Better docs for Vite folks #117
Conversation
🦋 Changeset detectedLatest commit: 94fb2eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Ismael <ismael@vercel.com>
Co-authored-by: Ismael <ismael@vercel.com>
|
Thanks for the update @tcc-sejohnson! I will port these changes to https://github.com/vercel/blob as well (which will be moved here soon). Would it make sense to update our svelte templates and scripts with this snippet? |
packages/kv/README.md
Outdated
| export default defineConfig(({ mode }) => { | ||
| // This check is important! | ||
| if (mode === 'development') { | ||
| const env = loadEnv(mode); |
There was a problem hiding this comment.
when testing locally I had to change it to
const env = loadEnv(mode, process.cwd())
I also noticed that loadEnv only loads VITE_ variables
There was a problem hiding this comment.
This didn't work for me. What did work:
if (mode === 'development') {
const env = loadEnv(mode, process.cwd(), '');
dotenvExpand.expand({parsed: env});
}There was a problem hiding this comment.
Hang it, I copied the wrong example. One sec...
There was a problem hiding this comment.
Thanks @IsaacBreen, didn't see your comment until I had already fixed the README! He's right @correttojs, I forgot you have to specify the third parameter (it's the prefix to load, defaults to VITE_).
There was a problem hiding this comment.
You're welcome! The {parsed: env} part is important too. Vite's loadEnv returns an object of env vars, but dotenvExpand.expand(config) looks for them under config.parsed .
There was a problem hiding this comment.
lol, thanks -- it's obviously too late over here for me to be useful
Definitely! It'll make them truly zero-config for people who clone them. |
Added a snippet explaining how to set up our clients with Vite (this has been the #1 issue filing reason thus far):
@vercel/postgres-kysely@vercel/postgres@vercel/kv@vercel/edge-config