support third-party connection strings #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eddd5af The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dferber90
force-pushed
the
dferber/fla-649-make-edge-config-sdk-testable-from-user
branch
from
abdcd21
to
a95bb5b
Compare
AndyBitz
approved these changes
May 22, 2023
dferber90
force-pushed
the
dferber/fla-649-make-edge-config-sdk-testable-from-user
branch
from
a95bb5b
to
922c38c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports external connection strings, except for just ones pointed to
edge-config.vercel.com.We keep supporting
edge-config.vercel.comas the main way to connect to Edge Configs, and as the only way we optimize. But we now also support having external connection strings.The reason we support external connection strings is that it makes testing
edge config really straightforward. Users can provide connection strings
pointing to their own servers and then either have a custom server
return the desired values or even intercept requests with something like
msw.
To allow interception we need a custom connection string as the
edge-config.vercel.com connection string might not always go over
the network, so msw would not have a chance to intercept.