Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typescript and typescript-eslint related dependencies #66

Closed
joulev opened this issue Jul 7, 2023 · 2 comments
Closed

Update typescript and typescript-eslint related dependencies #66

joulev opened this issue Jul 7, 2023 · 2 comments

Comments

@joulev
Copy link
Contributor

joulev commented Jul 7, 2023

TypeScript 5.1 has been out for a while now but @vercel/style-guide is still at peer dependency typescript@^4.8.0, causing warnings during installation:

 WARN  Issues with peer dependencies found
.
└─┬ @vercel/style-guide 4.0.2
  └── ✕ unmet peer typescript@^4.8.0: found 5.1.6

The @typescript-eslint/typescript-estree version used with @vercel/style-guide also doesn't support TypeScript 5.1

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.0.0

YOUR TYPESCRIPT VERSION: 5.1.6

Please only submit bug reports when using the officially supported version.

=============

I think it's time to release a new version with updated dependency and peer-dependency versions.
@matt-pawley
Copy link

👍 prettier version 3 is also now available and suffers the same problem.

joulev added a commit to joulev/vercel-style-guide that referenced this issue Aug 10, 2023
@joulev
build(deps): upgrade dependencies, switch to lint-staged
259ed46 
Closes vercel#65, closes vercel#66

The switch to lint-staged is forced because pretty-quick doesn't support Prettier v3.

BREAKING CHANGE: Now supports minimum Prettier 3 and TypeScript 5.1. If you use Next.js, minimum
version is now Next.js 13.

Signed-off-by: Vu Van Dung <me@joulev.dev>
@joulev joulev mentioned this issue Aug 10, 2023
Closed
@mwskwong mwskwong mentioned this issue Aug 17, 2023
Closed
mrmckeb added a commit that referenced this issue Aug 29, 2023
@mrmckeb
feat(eslint): upgrade @typescript/eslint and recommended configs
a1f7935 
Resolves #66

BREAKING CHANGE: Upgrading to `@typescript/eslint@6.x` may have have enabled additional rules.
mrmckeb added a commit that referenced this issue Aug 29, 2023
@mrmckeb
feat(eslint): upgrade @typescript/eslint and recommended configs
0d2e590 
Resolves #66

BREAKING CHANGE: Upgrading to `@typescript/eslint@6.x` may have have enabled additional rules.
mrmckeb added a commit that referenced this issue Aug 29, 2023
@mrmckeb
feat(eslint): upgrade @typescript-eslint/* and recommended configs
b6193a2 
Resolves #66

BREAKING CHANGE: Upgrading to `@typescript-eslint/*@6.x` may have have enabled additional rules.
@mrmckeb
Copy link
Contributor

mrmckeb commented Aug 29, 2023

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(deps): upgrade dependencies, switch to lint-staged joulev/vercel-style-guide
3 participants
@mrmckeb @matt-pawley @joulev