New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for expressions within template literals #80
Conversation
Conflicts: src/babel.js test/index.js
🎉 |
👏 |
Ran on a MacBook Pro (Mid 2014), 2.6 GHz Intel Core i5, 8 GB 1600 MHz DDR3 |
Anything we can do to help get this merged? |
Waiting on this 🍪 |
@TuckerWhitehouse @aga5tya I'd like to understand why it's 30% slower, seems a bit much? Also, @giuseppeg, what's the impact on an example that doesn't use expressions, before and after this patch? |
@rauchg what would be acceptable performance? I ran the benchmarks locally, and these are my results:
|
Re-ran the benchmarks, and updated
|
Thanks @rauchg, and nice work @giuseppeg! |
Fixes #25